[srslte-users] Issue in srslte_ofdm_tx_init() method (srsLTE release 19.12)

[Xavier Arteaga]

Hi Vikas,

Many thanks for your interest and for pointing this out. This section of
code is out-dated.

The for loop is irrelevant. As q->tmp is zeroed in srslte_ofdm_init_mbsfn_ just
after the allocation, the section of code is no longer required.

Regards,
Xavier




On Mon, 30 Nov 2020 at 09:15, Vikas Jain <vjain0974 at gmail.com> wrote:

>
> Hello,
>
> We are looking at the srslte_ofdm_tx_init() method in release 19.12 at:
> srsLTE/ofdm.c at release_19_12 · srsLTE/srsLTE · GitHub
> <https://github.com/srsLTE/srsLTE/blob/release_19_12/lib/src/phy/dft/ofdm.c>
>
> Relevant section of the function implementation is copy-pasted below for
> easy reference to the follow-on question:
>
> int srslte_ofdm_tx_init(srslte_ofdm_t* q, srslte_cp_t cp, cf_t*
> in_buffer, cf_t* out_buffer, uint32_t max_prb) { ...
>
> for (i = 0; i < q->nof_symbols; i++) {
>
> bzero(q->tmp, q->nof_guards * sizeof(cf_t));
>
> bzero(&q->tmp[q->nof_re + q->nof_guards], q->nof_guards * sizeof(cf_t));
>
> }
>
> ... }
>
>
>
> In the for-loop for nof_symbols, the index 'i' is not being used at all to
> index into the q->tmp array. Seems like this would initialize the guard
> sample region for only the first symbol. Is this the desired functionality?
> Could you please comment?
>
> Thanks.
> _______________________________________________
> srslte-users mailing list
> srslte-users at lists.softwareradiosystems.com
> http://www.softwareradiosystems.com/mailman/listinfo/srslte-users
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.srsran.com/pipermail/srsran-users/attachments/20201207/35d7b26d/attachment.htm>